Conversation
plorenz
force-pushed
the
add-multi-underlay-doc
branch
from
57f5826 to
eb2461b
Compare
MULTI_UNDERLAY_PROTOCOL.md
Outdated
| An `Underlay` represents a single underlying transport connection (TCP, WebSocket, UDP, etc.). Multiple underlays can be grouped together under a single multi-channel using a shared group secret. | ||
|
|
||
| ### Group Secret | ||
| A cryptographic token that identifies which underlays belong to the same logical channel. All underlays sharing the same group secret are considered part of the same multi-channel group. |
Member
There was a problem hiding this comment.
I took a quick look to see what cryptographic algorithms are used to generate these symmetric secrets. I could not find an implementation. It seems like it is up to the caller to decide the value. Might be worth documenting.
Member
Author
There was a problem hiding this comment.
Mmm, I should fix that. It's not cryptographic, it's just a uuid used as a shared secret.
Member
Author
There was a problem hiding this comment.
Updated group secret text and also added a section for connection id
andrewpmartinez
approved these changes
Aug 20, 2025
plorenz
force-pushed
the
add-multi-underlay-doc
branch
from
eb2461b to
4604876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.